Codecov Report

Merging #1934 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1934      +/-   ##
==========================================
+ Coverage   51.57%   51.59%   +0.01%     
==========================================
  Files         242      242              
  Lines       14246    14241       -5     
==========================================
  Hits         7348     7348              
+ Misses       6898     6893       -5

Can you explain the rationale behind this change? Are the DASH streams broken - perhaps this is a bug that needs fixing instead of dropping the streams. Pinging @melmorabity.

No need to comment out code, if you want to remove it, remove it - the function of version control is to avoid this kind of behaviour.

The problem is that the video stream takes 5 seconds to start and then a few seconds later nothing more. I have a closer look and I think the problem comes from the website and not from streamlink.

this could be a streamlink issue rather than a plugin issue

only the init video will be played,
everything else will be downloaded in the background but won't be played.

it works in the webbrowser

https://www.france.tv/france-3/direct.html
https://gist.github.com/back-to/31e8367af1b9a177054e28de72bc59f4/revisions

Okay, however, if it's a streamlink problem I don't have enough knowledge to fix it or even find it.
However, I recommend that you accept my pull request until you find and fix the problem.

What are you going to do to fix the problem?

I don't know how much work it is to fix the dash stream,
but if you want it removed temporarily,
you should remove all related dash code

see when it was added 84a2f90#diff-57d44e5f969dec7c7a4f48de4c3f2c8b

or you can ignore the dash streams with --stream-types hls,hds

https://streamlink.github.io/cli.html#cmdoption-stream-types

also the issue is related to

when the audio and video gets muxed

when self.video_representation or self.audio_representation gets played alone,
without calling open on the other type, they work.