Add window title to PotPlayer #2224

RomanKornev · 2019-01-01T22:07:58Z

After #1576 we can add window title support to other players.

Due to limitations of PotPlayer, titles can only be added to URL streams and there is no separate title argument.
PotPlayer command line documentation in PotPlayer - About - Command Line:

You can specify titles for URLs by separating them with a backslash (\) at the end of URLs. ("http://...\title of this url")

Because of this, the title needs to be appended at the end of the filename so args need to be formatted after player check.

Here's an example of it working on Windows 10:

codecov · 2019-01-01T23:24:04Z

Codecov Report

Merging #2224 into master will increase coverage by 0.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2224      +/-   ##
==========================================
+ Coverage   52.36%   52.65%   +0.28%     
==========================================
  Files         237      237              
  Lines       14712    14751      +39     
==========================================
+ Hits         7704     7767      +63     
+ Misses       7008     6984      -24

codecov · 2019-01-01T23:24:04Z

Codecov Report

Merging #2224 into master will decrease coverage by 0.18%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master    #2224      +/-   ##
==========================================
- Coverage   52.36%   52.18%   -0.19%     
==========================================
  Files         237      237              
  Lines       14712    14715       +3     
==========================================
- Hits         7704     7679      -25     
- Misses       7008     7036      +28

RomanKornev · 2019-01-02T21:20:47Z

Added tests

beardypig · 2019-01-03T12:08:24Z

Thanks for the PR @RomanKornev. Does the titles work with named pipes too? Maybe PotPlayer doesn't work with named pipes anyway. Can you test it with a title that has some quote characters? eg. --title "A \"{title}\""?

RomanKornev · 2019-01-03T15:57:39Z

Does the titles work with named pipes too? Maybe PotPlayer doesn't work with named pipes anyway.

It doesn't work with named pipes: https://streamlink.github.io/players.html.
Is filename always "-" for regular stdin pipes?
In that case, title should remain Streaming media (stdin). Sadly, I haven't found a way to feed a title using stdin pipe to PotPlayer.

Can you test it with a title that has some quote characters? eg. --title "A \"{title}\""?

Upon further examination, PotPlayer just deletes any quotes anyway and doesn't recognize anything after closing quote. So before \"STREAMTITLE\" after would be before STREAMTITLE.
In that case, it might be better to just explicitly delete double quotes before passing the title.
Then --title "before \"{title}\" \"{author}\" after" would be before STREAMTITLE AUTHOR after.

back-to · 2019-01-11T12:46:50Z

src/streamlink_cli/constants.py

    "vlc": ["vlc", "vlc.exe"],
-    "mpv": ["mpv", "mpv.exe"]
+    "mpv": ["mpv", "mpv.exe"],
+    "pot": ["potplayer", "potplayermini64.exe", "potplayermini.exe"]


is there even a potplayer binary? as this player is windows only.

Now tests are failing

Failing test:

self.assertEqual("potplayer", PlayerOutput.supported_player("C:\\PotPlayer\\PotPlayerMini64.exe"))

Unable to reproduce on Windows. Something to do with

streamlink/src/streamlink_cli/output.py

Lines 123 to 132 in 6df8835

if not is_win32:

# under a POSIX system use shlex to find the actual command

# under windows this is not an issue because executables end in .exe

cmd = shlex.split(cmd)[0]

cmd = os.path.basename(cmd.lower())

for player, possiblecmds in SUPPORTED_PLAYERS.items():

for possiblecmd in possiblecmds:

if cmd.startswith(possiblecmd):

return player

Is .exe getting split?

it can't work there with cmd.startswith(possiblecmd)
seems like you need potplayer as a binary here to avoid bigger code changes

this is the output on linux

_________________________________________________________________________________________________________ TestPlayerOutput.test_supported_player_args_win32 _________________________________________________________________________________________________________ self = <tests.test_output.TestPlayerOutput testMethod=test_supported_player_args_win32> @patch("streamlink_cli.output.os.path.basename", new=ntpath.basename) def test_supported_player_args_win32(self): self.assertEqual("mpv", PlayerOutput.supported_player("C:\\MPV\\mpv.exe --argh")) self.assertEqual("vlc", PlayerOutput.supported_player("C:\\VLC\\vlc.exe --argh")) self.assertEqual("potplayer", > PlayerOutput.supported_player("C:\\PotPlayer\\PotPlayerMini64.exe --argh")) E AssertionError: 'potplayer' != None tests/test_output.py:43: AssertionError ----------------------------------------------------------------------------------------------------------------------- Captured stdout call ------------------------------------------------------------------------------------------------------------------------ --- player = vlc cmd = mpvmpv.exe possiblecmd = vlc possiblecmd = vlc.exe --- player = mpv cmd = mpvmpv.exe possiblecmd = mpv --- player = vlc cmd = vlcvlc.exe possiblecmd = vlc --- player = vlc cmd = potplayerpotplayermini64.exe possiblecmd = vlc possiblecmd = vlc.exe --- player = mpv cmd = potplayerpotplayermini64.exe possiblecmd = mpv possiblecmd = mpv.exe --- player = potplayer cmd = potplayerpotplayermini64.exe possiblecmd = potplayermini64.exe possiblecmd = potplayermini.exe ___________________________________________________________________________________________________________ TestPlayerOutput.test_supported_player_win32 ____________________________________________________________________________________________________________ self = <tests.test_output.TestPlayerOutput testMethod=test_supported_player_win32> @patch("streamlink_cli.output.os.path.basename", new=ntpath.basename) def test_supported_player_win32(self): self.assertEqual("mpv", PlayerOutput.supported_player("C:\\MPV\\mpv.exe")) self.assertEqual("vlc", PlayerOutput.supported_player("C:\\VLC\\vlc.exe")) self.assertEqual("potplayer", > PlayerOutput.supported_player("C:\\PotPlayer\\PotPlayerMini64.exe")) E AssertionError: 'potplayer' != None tests/test_output.py:27: AssertionError ----------------------------------------------------------------------------------------------------------------------- Captured stdout call ------------------------------------------------------------------------------------------------------------------------ --- player = vlc cmd = mpvmpv.exe possiblecmd = vlc possiblecmd = vlc.exe --- player = mpv cmd = mpvmpv.exe possiblecmd = mpv --- player = vlc cmd = vlcvlc.exe possiblecmd = vlc --- player = vlc cmd = potplayerpotplayermini64.exe possiblecmd = vlc possiblecmd = vlc.exe --- player = mpv cmd = potplayerpotplayermini64.exe possiblecmd = mpv possiblecmd = mpv.exe --- player = potplayer cmd = potplayerpotplayermini64.exe possiblecmd = potplayermini64.exe possiblecmd = potplayermini.exe

Reverted back to previous binary name.

back-to · 2019-01-11T12:51:04Z

src/streamlink_cli/constants.py

    "vlc": ["vlc", "vlc.exe"],
-    "mpv": ["mpv", "mpv.exe"]
+    "mpv": ["mpv", "mpv.exe"],
+    "pot": ["potplayer", "potplayermini64.exe", "potplayermini.exe"]


Potplayer is always used as Potplayer

I can't find any references with just the name pot
so it should be named potplayer instead of pot

-- Remove potplayer binary name -- Fix tests

RomanKornev added 2 commits January 1, 2019 23:02

[ADD] PotPlayer window title

808dc12

[FIX] Title enclosed in quotes

2e53be0

RomanKornev added 3 commits January 2, 2019 23:53

[ADD] PotPlayer title test

951584e

[ADD] Author and default title PotPlayer tests

4416548

[ADD] Test supported PotPlayer

45d1d72

[FIX] Negative test

82b7132

[FIX] Double quotes

bb37271

back-to reviewed Jan 11, 2019

View reviewed changes

back-to added the enhancement label Jan 11, 2019

RomanKornev added 2 commits January 11, 2019 16:12

[RENAME] pot -> potplayer

fddd767

-- Remove potplayer binary name -- Fix tests

[FIX] Potplayer binary name

b48d6c6

back-to approved these changes Feb 1, 2019

View reviewed changes

back-to merged commit 5075a5e into streamlink:master Feb 9, 2019

RomanKornev deleted the potplayer-title branch February 11, 2019 11:02

jackyzy823 pushed a commit to jackyzy823/streamlink that referenced this pull request Mar 20, 2019

cli.output: Add window title for PotPlayer (streamlink#2224)

2b531bb

Billy2011 pushed a commit to Billy2011/streamlink-27 that referenced this pull request May 14, 2020

cli.output: Add window title for PotPlayer (streamlink#2224)

edf3332

mkbloke pushed a commit to mkbloke/streamlink that referenced this pull request Aug 18, 2020

cli.output: Add window title for PotPlayer (streamlink#2224)

b00808c

resiproxy pushed a commit to resiproxy/streamlink that referenced this pull request Nov 5, 2020

cli.output: Add window title for PotPlayer (streamlink#2224)

4b619d2

	if not is_win32:
	# under a POSIX system use shlex to find the actual command
	# under windows this is not an issue because executables end in .exe
	cmd = shlex.split(cmd)[0]

	cmd = os.path.basename(cmd.lower())
	for player, possiblecmds in SUPPORTED_PLAYERS.items():
	for possiblecmd in possiblecmds:
	if cmd.startswith(possiblecmd):
	return player

Uh oh!

Add window title to PotPlayer #2224

Add window title to PotPlayer #2224

Uh oh!

Conversation

RomanKornev commented Jan 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Jan 1, 2019

Codecov Report

Uh oh!

RomanKornev commented Jan 2, 2019

Uh oh!

beardypig commented Jan 3, 2019

Uh oh!

RomanKornev commented Jan 3, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RomanKornev commented Jan 1, 2019 •

edited

Loading

codecov bot commented Jan 1, 2019 •

edited

Loading