Merged
Conversation
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
Collaborator
Author
|
Note that in any case, this package does not work with Node <0.10 since iconv-lite removed support for Node.js <0.10 starting from version >=0.5, so this change is not a big issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There really isn’t a very neat solution. Technically this would be a breaking change, but the change was documented. We could either do this or remove the engines field in version 3, and then in version 4 establish a new engines field. closes #92