[Mainnet/Testnet] Add Decimals Property #17
Closed
mrtpain wants to merge 6 commits intostratisproject:masterfrom
Closed
[Mainnet/Testnet] Add Decimals Property #17mrtpain wants to merge 6 commits intostratisproject:masterfrom
mrtpain wants to merge 6 commits intostratisproject:masterfrom
Conversation
This was referenced Dec 31, 2020
This was referenced Jan 13, 2021
YakupIpek
suggested changes
Jan 16, 2021
Mainnet/StandardToken/StandardToken.Tests/StandardTokenTests.cs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@YakupIpek Updated, adjusted tests and added README For future reference, the decision was to use a Call(ContractAddress, 0, $"get_{nameof(Property)}", null);I lumped Testnet in this PR as well now so Testnet and Mainnet are identical. |
Contributor
|
We should not release this code until a sufficient number of nodes have upgraded to PR 365: stratisproject/StratisFullNode#365. |
Collaborator
Author
|
Closing now that this is a dup PR - #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a decimals property to the standard token contract, used for display and calculation purposes.
Bytecode