Skip to content

SSAS and Stratis Transaction Handoff#68

Merged
fassadlr merged 2 commits intostratisproject:masterfrom
Opdex:feature/txShortcutAndSsas
Dec 23, 2021
Merged

SSAS and Stratis Transaction Handoff#68
fassadlr merged 2 commits intostratisproject:masterfrom
Opdex:feature/txShortcutAndSsas

Conversation

@mrtpain
Copy link
Contributor

@mrtpain mrtpain commented Dec 14, 2021

Work in progress pull request to implement Stratis Signature Authentication and Stratis Transaction Handoff into the Cirrus Core wallet.

Stratis Signature Authentication

Follows SSAS guidelines for message signature and authentication flows adding a new button to the dashboard view.

image

image

Stratis Transaction Handoff

Adds a text input into the smart contract transaction modal, allowing copy/paste QR code functionality into Cirrus Core. Matches in-progress functionality of mobile wallets.

image

Other Fixes and Improvements

  • SVG Loader component removing code duplication
  • Integrations Service and implementation of SSAS and Transaction Shortcut callbacks
  • Creates shareable getHttpOptions method
  • Adds sign message endpoint to api service
  • Increased default gasCallRecommendedLimit from 50,000 to 125,000
    • Covers most all Opdex related transactions w/ default gas cost

Future Considerations

  • Consider adding a "preview" step to make the local-call of the transaction, resulting in a quote to present to the user and potentially prevent accidental mistakes and wasted gas.
  • This PR does not cover token management of UInt256 token balances, token creation, transfers, or allowances

@mrtpain mrtpain marked this pull request as ready for review December 14, 2021 19:37
@mrtpain mrtpain changed the title [WIP] SSAS and Transaction Shortcut Helper SSAS and Straits Transaction Handoff Dec 14, 2021
@mrtpain mrtpain changed the title SSAS and Straits Transaction Handoff SSAS and Stratis Transaction Handoff Dec 14, 2021
@fassadlr
Copy link
Contributor

Good work Tyler!

@fassadlr fassadlr merged commit 2b69781 into stratisproject:master Dec 23, 2021
@mrtpain mrtpain deleted the feature/txShortcutAndSsas branch December 23, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants