SSAS and Stratis Transaction Handoff#68
Merged
fassadlr merged 2 commits intostratisproject:masterfrom Dec 23, 2021
Merged
Conversation
…ction handoff request models, fix reset tx handoff bug
fassadlr
approved these changes
Dec 23, 2021
Contributor
|
Good work Tyler! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress pull request to implement Stratis Signature Authentication and Stratis Transaction Handoff into the Cirrus Core wallet.
Stratis Signature Authentication
Follows SSAS guidelines for message signature and authentication flows adding a new button to the dashboard view.
Stratis Transaction Handoff
Adds a text input into the smart contract transaction modal, allowing copy/paste QR code functionality into Cirrus Core. Matches in-progress functionality of mobile wallets.
Other Fixes and Improvements
getHttpOptionsmethodgasCallRecommendedLimitfrom50,000to125,000Future Considerations
local-callof the transaction, resulting in a quote to present to the user and potentially prevent accidental mistakes and wasted gas.UInt256token balances, token creation, transfers, or allowances