fix: prevent in-place mutation of message history in normalizer#2326
Open
pipe1os wants to merge 5 commits into
Open
fix: prevent in-place mutation of message history in normalizer#2326pipe1os wants to merge 5 commits into
pipe1os wants to merge 5 commits into
Conversation
…-history-mutation # Conflicts: # strands-py/src/strands/event_loop/streaming.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a state corruption bug where
_normalize_messagesmutated theagent.messageshistory in place during streaming. This permanently altered the canonical conversation state before it reached the session manager. Changed the normalization loop to build shallow copies so the original message history remains pristine.Related Issues
N/A
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.