Merged
Conversation
With the merge of ether/etherpad-lite#3268, `getLineHTMLForExport` should not return anything, but instead set the HTML content of the line on `context.lineContent`. Fix https://trello.com/c/31tPK2O3/1680.
joassouza
approved these changes
Feb 21, 2019
joassouza
left a comment
There was a problem hiding this comment.
refatorar para constantes ajudou muito na leitura dos testes!
Author
|
Nossa, nem me fale! Perdi mais tempo tentando entender o que os testes faziam do que corrigindo o bug. Agora ficou bem mais claro mesmo 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the merge of PR 3268 on Etherpad,
getLineHTMLForExportshould not return anything, but instead set the HTML content of the line oncontext.lineContent.Fix https://trello.com/c/31tPK2O3/1680.