Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

[Bug] Update testing-library/dom@9 to support @testing-library/react@14 #33

@rothsandro

Description

@rothsandro

Describe the bug

We use @testing-library/react for our tests (outside of Storybook).
After updating to version 14, our tests still pass but log many errors:

Warning: An update to TemplatesRenderer inside a test was not wrapped in act(...).

This is caused by an incompatible dependency of @testing-library/dom. @testing-library/react@14 needs v9 of the DOM package but @storybook/testing-library@0.0.14-next.1 still uses v8 and because of that npm installs version 8. If we manually install v9 of the package all errors are gone (but we shouldn't have to add it as a depdency).

See: testing-library/user-event#1104

Expected behavior

@storybook/testing-library should update to @testing-library/dom@9.

Environment

  • OS: Windows 11
  • Node.js version: 16.18.0
  • NPM version: 8.19.2

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions