Fix os and tty modules being emptied with Expo API Routes#876
Merged
Conversation
🦋 Changeset detectedLatest commit: f0f3f8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nezz
commented
Apr 11, 2026
| return { | ||
| type: 'empty', | ||
| }; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
The intention behind doing this when storybook is disabled wasn't clear to me, but this could be re-added if needed with the web check
Member
There was a problem hiding this comment.
Its because I had some reports of these packages getting pulled in somehow even when storybook was disabled
Contributor
Author
There was a problem hiding this comment.
Oh wow, not sure how that could happen 😅
Member
There was a problem hiding this comment.
Yeah i don't know, just metro things 😅
Member
|
Makes sense, thanks for the pr 🙏 |
dannyhw
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
withStorybookreplaces os and tty with empty modules on all platforms, breaking Expo API RoutesWhat I did
withStorybookunconditionally resolved os and tty to{ type: "empty" }as a workaround. This breaks Expo API Routes (which bundle for the web platform) when any server-side dependency needs real Node built-ins likeos.hostname().Changes:
platform !== 'web'), so web/server bundles get the real Node modules.storybook/@storybookimports are already emptied, so the instrumentor is never loaded and its os/tty imports are never reached.How to test
@storybook/react-nativerequire("os")(e.g.os.hostname())os.hostname is not a functionerrorsIf your answer is yes to any of these, please make sure to include it in your PR.