fix: add missing storybook dev dependency to ondevice packages#854
Merged
Conversation
Several packages were missing storybook as a devDependency, which could cause type-checking and build issues.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storybookas a devDependency to 7 packages that were missing it:ondevice-actions,ondevice-backgrounds,ondevice-controls,ondevice-notes,react-native-ui-common,react-native-ui-lite,react-native-uistorybookpackage could be resolved in the dependency tree, causing duplicate module instances at runtimeProblem
The missing devDependency caused:
fn()fromstorybook/testnot applying — thefn()mock listener Set is module-scoped, so when packages resolved a different copy ofstorybook/test, mocks registered in user-land code weren't visible to the addonTest plan
pnpm install && pnpm buildcompletes without errorsfn()mocks fromstorybook/testappear correctly in the actions panel