Skip to content
This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Operator shouldn't tolerate NoSchedule taint#340

Merged
croomes merged 1 commit intomasterfrom
remove-toleration
Jun 11, 2021
Merged

Operator shouldn't tolerate NoSchedule taint#340
croomes merged 1 commit intomasterfrom
remove-toleration

Conversation

@croomes
Copy link
Contributor

@croomes croomes commented Jun 11, 2021

The uber-yaml sets the Operator pod to tolerate NoSchedule, which it doesn't need to do. Tolerations for the other components are set in the StorageOSCluster CR and remain unchanged.

@croomes croomes requested review from avestuk, darkowlzz and mhmxs June 11, 2021 12:36
@avestuk
Copy link
Contributor

avestuk commented Jun 11, 2021

LGTM - Github isn't letting me approve it for some reason.

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@croomes croomes merged commit 6bad111 into master Jun 11, 2021
@croomes croomes deleted the remove-toleration branch June 11, 2021 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants