This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Conversation
darkowlzz
reviewed
Jun 3, 2021
pkg/storageos/rbac.go
Outdated
| SchedulerClusterRoleName = "storageos:scheduler-extender" | ||
| SchedulerClusterBindingName = "storageos:scheduler-extender" | ||
|
|
||
| SchedulingClusterRoleName = "storageos:scheduling-extender" |
Contributor
There was a problem hiding this comment.
Scheduler for kube-scheduler and Scheduling for the extender could be confusing.
How about SchedExt or SchedulerExt?
Contributor
Author
There was a problem hiding this comment.
The suggested names are also confusing for me. Which one is which? Let me find some better name for them.
darkowlzz
reviewed
Jun 4, 2021
pkg/storageos/rbac.go
Outdated
| SchedulerClusterRoleName = "storageos:scheduler-extender" | ||
| SchedulerClusterBindingName = "storageos:scheduler-extender" | ||
| KubeSchedulerClusterRoleName = "storageos:kube-scheduler" | ||
| KubeSchedulerClusterBindingName = "storageos:kube-scheduler" |
Contributor
There was a problem hiding this comment.
This name change is good but I'm afraid we shouldn't change an existing resource name. This will require migration process/step to the new version.
9fee94f to
1c6273c
Compare
croomes
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New implementation of scheduler uses api server to detect pod volume types, and it needs more rights to do.