This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Conversation
mhmxs
approved these changes
Apr 22, 2021
croomes
approved these changes
Apr 22, 2021
Contributor
croomes
left a comment
There was a problem hiding this comment.
Thanks, just a suggestion about the logging, but fine to merge as-is if preferred.
5a08c9b to
a6bf70f
Compare
The webhook resource migration runs at operator startup, before the controllers are started and ensures that the old webhook related resources are deleted if they are found. The migration has a timeout of 20 seconds. If the migration gets stuck for some reason, the timeout context will help cancel the migration operations and return failure. Also adds fake k8s client based test and kind based e2e tests.
761a47a to
79a35d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webhook resource migration runs at operator startup, before the
controllers are started and ensures that the old webhook related
resources are deleted if they are found. The migration has a timeout of
20 seconds. If the migration gets stuck for some reason, the context
timeout will help cancel the migration operations and return failure.
Log message when some legacy resource is found and deleted:
Nothing is logged when no legacy resource is found.
Also adds fake k8s client based test and kind based e2e tests.
The operator-sdk local run command is updated to have valid options and
the go.sum file is updated with
make tidy.