This repository was archived by the owner on Nov 9, 2022. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Move pod scheduler webhook to api-manager#315
Merged
Conversation
darkowlzz
reviewed
Apr 6, 2021
darkowlzz
reviewed
Apr 6, 2021
c72c77a to
e7685f9
Compare
darkowlzz
reviewed
Apr 7, 2021
b483439 to
a463742
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the pod scheduler mutating webhook server to the api-manager: storageos/api-manager#40
The operator is now only responsible for creating the webhook configuration, the service and the RBAC rules required by api-manager.
Previously,
DISABLE_SCHEDULER_WEBHOOKcould be set as an environment variable on the operator to disable the scheduler and to not set up the webhook server or configuration rules.Since we will now have multiple handlers all requiring the webhook (there will be two: one mutating, another validating), there is no longer an option not to create the webhook configuration. Instead, to disable the Pod scheduler, set
disableScheduler=truein the StorageOSCluster CR. This is the same as before and makes the pod scheduler webhook a no-op.