Skip to content

[wip] added example tests#1

Open
GavinJoyce wants to merge 2 commits intomasterfrom
gj/tests
Open

[wip] added example tests#1
GavinJoyce wants to merge 2 commits intomasterfrom
gj/tests

Conversation

@GavinJoyce
Copy link
Copy Markdown
Collaborator

@GavinJoyce GavinJoyce commented Jan 24, 2018

screen shot 2018-01-25 at 19 50 05

// Set any properties with this.set('myProperty', 'value');
// Handle any actions with this.on('myAction', function(val) { ... });

this.render(hbs`{{x-button}}`);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GavinJoyce shouldn't this be {{mu-first-post:x-button}} ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or whatever the namespace syntax is 😖

Copy link
Copy Markdown
Collaborator Author

@GavinJoyce GavinJoyce Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test seems to fail with {{mu-first-post:x-button}}:

screen shot 2018-01-25 at 19 45 52

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think this might have something to do with the resolver 🤔 I'm not even sure if the work myself and @rwjblue did even touched on exporting non "main" components in the way that the resolver is expecting (I'm not even sure I'm saying it right there)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just had a look back at what we're doing and I remember now 🎉 the dummy app in this addon is intended to be a test of the new MU addon being included into a classic app. The ember-cli version we're using makes use of the (broccoli-module-unification-reexporter)[https://github.com/ember-cli/ember-cli/blob/mu-addons/package.json#L54) plugin that re-exports the components as "non namespaced" components.

I don't know the best way to proceed 😕

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. My aim here was to discover what was needed for tests in an addon. I think I've learned enough to apply this to the ember g component blueprint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants