Merged
Conversation
Owner
|
Sorry, will be some delay, having problems getting coverage to work in my dev environment. |
Owner
|
Thank goodness for dev environments on multiple boxes. Coverage is fine, thanks for taking the time to do these tests. You may, if you want, add testing for JSONObject.query() and JSONArray.query(), otherwise I can add them. JunitTestSuite.java should have JSONPointer.class added to the SuiteClasses annotation. Otherwise all looks OK so far. |
Contributor
|
Maybe just add a test for this: Builder b = JSONPointer.builder().append("key1");
JSONPointer jp1 = b.build();
b.append("key2");
JSONPointer jp2 = b.build();
if(jp1.toString().equals(jp2.toString()){
throw new Exception("Oops, my pointers are sharing a backing array");
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for this PR: stleary/JSON-java#222