Skip to content

(Closes #466) Fix for "==" when matching implicit loop in array constructor#467

Merged
LonelyCat124 merged 4 commits intomasterfrom
466_parentheses_in_all
Jul 21, 2025
Merged

(Closes #466) Fix for "==" when matching implicit loop in array constructor#467
LonelyCat124 merged 4 commits intomasterfrom
466_parentheses_in_all

Conversation

@arporter
Copy link
Member

No description provided.

@arporter arporter self-assigned this Jun 17, 2025
@arporter arporter added the bug label Jun 17, 2025
@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (370884f) to head (2a0cabc).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   92.15%   92.15%           
=======================================
  Files          86       86           
  Lines       13734    13734           
=======================================
+ Hits        12656    12657    +1     
+ Misses       1078     1077    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter
Copy link
Member Author

This is ready for review from anyone :-)

Copy link

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arporter
Looks good to me, the only question I have is should we apply the auto copyright updating script to fparser as well as PSyclone?

@LonelyCat124 LonelyCat124 added ready for merge PR is waiting on final CI checks before being merged. and removed ready for review labels Jul 17, 2025
@arporter
Copy link
Member Author

Looks good to me, the only question I have is should we apply the auto copyright updating script to fparser as well as PSyclone?

Yes, we could do that. Would be a separate PR of course.

@LonelyCat124 LonelyCat124 merged commit 77e0dd5 into master Jul 21, 2025
5 checks passed
@LonelyCat124 LonelyCat124 deleted the 466_parentheses_in_all branch July 21, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug ready for merge PR is waiting on final CI checks before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants