Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 86 86
Lines 13834 13834
=======================================
Hits 12747 12747
Misses 1087 1087 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
The CI failure is not caused by this PR: I could manually trigger the 3.8 run, but 3.11 keeps on getting cancelled |
Member
|
We had this problem with the PSyclone repo too - we had to downgrade the version of Ubuntu used for the runner in order to retain 3.7 support. |
Collaborator
|
@hiker If you bring it to master now the CI issue may get resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #458:
ModuleNameprivate (these can cause compilation failures if wildcard imports are used, because a module then ends up with two conflicting definitions). The code does not change anything atm (i.e. the list of names to ignore is empty), so no change unless a user changes this definition. We do this in our LFRic-build environment for example.