Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
=========================================
Coverage ? 92.13%
=========================================
Files ? 85
Lines ? 13824
Branches ? 0
=========================================
Hits ? 12737
Misses ? 1087
Partials ? 0 ☔ View full report in Codecov by Sentry. |
arporter
requested changes
Oct 7, 2024
Member
arporter
left a comment
There was a problem hiding this comment.
Looks good Joerg, thanks for adding to the docs and adding tests. Just a bit of tidying required.
Collaborator
Author
|
I also did some very minor pylint fixes. Strangely, black allows more than 80 characters per line, it undid some of my fixes :) |
arporter
approved these changes
Oct 11, 2024
Member
arporter
left a comment
There was a problem hiding this comment.
All good now, thanks for the tidying.
Yes, Black allows a slightly longer line-length because (their docs say) it resulted in a lot fewer broken lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a script that removes all private and protected attributes (which is used in PSyclone's kernel extraction).
Added a chapter explaining the examples to the manual, added tests for examples (triggered in CI), and added me as author.