fix type guard stmt bug and update tests.#438
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 91.96% 92.02% +0.05%
==========================================
Files 85 85
Lines 13644 13643 -1
==========================================
+ Hits 12548 12555 +7
+ Misses 1096 1088 -8 ☔ View full report in Codecov by Sentry. |
arporter
requested changes
Jan 3, 2024
Member
arporter
left a comment
There was a problem hiding this comment.
Good job. Just a couple of minor things to tidy up and then this can go on.
No need to update docs as this is a bug fix.
Member
|
I'll take this on - there's not much to do. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #438 +/- ##
==========================================
+ Coverage 92.07% 92.13% +0.05%
==========================================
Files 85 85
Lines 13825 13824 -1
==========================================
+ Hits 12730 12737 +7
+ Misses 1095 1087 -8 ☔ View full report in Codecov by Sentry. |
Member
|
Just finishes off a small bugfix. Ready for review from either @hiker or @sergisiso. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the type_guard_stmt match method. Updated the code and associated tests. The restructuring of the code actually removes the offending line of code.