Skip to content

#304 add pip_requirements file and doc target in setup.py#305

Merged
rupertford merged 2 commits intomasterfrom
304_rtd_build_fix
Dec 2, 2021
Merged

#304 add pip_requirements file and doc target in setup.py#305
rupertford merged 2 commits intomasterfrom
304_rtd_build_fix

Conversation

@arporter
Copy link
Member

@arporter arporter commented Nov 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #305 (0b9d77c) into master (ee5c0e8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   90.95%   90.95%           
=======================================
  Files          35       35           
  Lines       12917    12917           
=======================================
  Hits        11749    11749           
  Misses       1168     1168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5c0e8...0b9d77c. Read the comment docs.

@arporter
Copy link
Member Author

arporter commented Nov 4, 2021

Very small change that just kicks the RTD build into shape. One for either @rupertford or @sergisiso.

Copy link
Collaborator

@rupertford rupertford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Approving.

@rupertford rupertford added ready for merge PR is waiting on final CI checks before being merged. and removed under review labels Dec 2, 2021
@rupertford rupertford merged commit 6558244 into master Dec 2, 2021
@rupertford rupertford deleted the 304_rtd_build_fix branch December 2, 2021 13:26
@rupertford rupertford mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for merge PR is waiting on final CI checks before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants