feat(guardian): add quality-review as Deacon plugin#2263
Closed
rsionnach wants to merge 1 commit intogastownhall:mainfrom
Closed
feat(guardian): add quality-review as Deacon plugin#2263rsionnach wants to merge 1 commit intogastownhall:mainfrom
rsionnach wants to merge 1 commit intogastownhall:mainfrom
Conversation
Replace the Go-based Guardian persistence layer (internal/guardian/, gt judgment CLI, trend_monitor.go) with a wisp-based plugin approach: - Add plugins/quality-review/plugin.md: Deacon plugin that runs every 6h, queries quality-review-result wisps, computes per-worker trends, and alerts mayor on quality breaches - Update mol-refinery-patrol formula (v4->v5): add quality-review step between run-tests and handle-failures that records results as wisps via bd create --ephemeral - Add judgment_enabled/review_depth formula variables (opt-in, default off) No Go code changes. Phase 1 measurement-only (does not gate merges). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
steveyegge
added a commit
that referenced
this pull request
Mar 2, 2026
Replace Go-based Guardian persistence layer (PRs #2167-#2169) with wisp-based approach. Adds quality-review step to mol-refinery-patrol formula (v8->v9) and Deacon plugin for per-worker trend analysis. Formula step: measurement-only Phase 1 between run-tests and handle-failures. Fail-open design — records scores as ephemeral wisps, never gates merges. Controlled by judgment_enabled (default false) and review_depth vars. Plugin: runs every 6h, queries result wisps, computes per-worker averages and trends, alerts mayor and escalates on quality breaches (avg < 0.45). Fix-merged from PR #2263 with: rebased onto v8, added template vars for config injection, aligned bd create syntax with existing plugin conventions, added gt escalate on failure path. Co-Authored-By: Rob Fox <r.sionnach@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Fix-merged to main as bd47754. Rebased onto formula v8→v9, fixed template variable injection, aligned bd create syntax with existing plugin conventions, added gt escalate on failure path. Thanks @rsionnach! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plugins/quality-review/plugin.md— town-level Deacon plugin that runs every 6h, queries quality-review-result wisps, computes per-worker trends, and alerts mayor on quality breachesmol-refinery-patrolformula (v4→v5) with aquality-reviewstep betweenrun-testsandhandle-failuresthat records results as wisps viabd create --ephemeraljudgment_enabled(default"false") andreview_depth(default"standard") formula variables for per-rig opt-inNo Go code changes. No new packages, CLIs, config types, or event types. Phase 1 measurement-only (does not gate merges).
Test plan
go build ./...passes (no Go changes besides formula TOML)go test ./internal/formula/...passes (formula parses correctly)gt plugin listdiscovers quality-review plugingt plugin show quality-reviewdisplays plugin detailsjudgment_enabled=true🤖 Generated with Claude Code