Twitter Timeline: add DNT option via filter.#1
Closed
jeherve wants to merge 6 commits intostevenlinx:i6722from
Closed
Twitter Timeline: add DNT option via filter.#1jeherve wants to merge 6 commits intostevenlinx:i6722from
jeherve wants to merge 6 commits intostevenlinx:i6722from
Conversation
Author
|
closing as I have now merged the changes into Automattic#9359 directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Automattic#9359
Here is a different take on Automattic#9359. It seems simpler to me, and does not make any changes to defaults or the
updatefunction since we do not have any UI for that setting in the widget settings.I have also set the option to false by default, to match Twitter's own settings.