Add test to assert for issue 88#92
Merged
steveklabnik merged 1 commit intodtolnay:masterfrom Oct 1, 2016
Byron:master
Merged
Conversation
#88 It looks like the problem is in the `semver_parser` though.
Contributor
|
I merged steveklabnik/semver-parser#5 but will have to cut a release before this will pass. |
Contributor
|
I kicked off a new build, let's see! |
Contributor
Author
|
@steveklabnik Looks good to me ! |
Contributor
|
Awesome. Cutting a new release. |
Contributor
|
Released 0.4.1. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once this PR succeeds in CI, #88 can be considered fixed.
Will have a look at the
semver_parsercrate next.