Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge updates Glaze to begin requiring C++23. There are no breaking C++20 changes here, but this will allow Glaze development to begin introducing C++23 features and performance improvements.
All compilers that built Glaze with C++20 already support C++23, so this should not be an issue for users.
With the v3.0.0 release coming, it makes sense to make this change now, rather than waiting for v4.0.0
A big reason to move to C++23 is the support for
static constexprwithin constexpr functions, which will allow the underlying architecture to be cleaner.There are a number of other features that will clean up Glaze, e.g. removing
glz::expected, std::string'sresize_and_overwrite, more constexpr support, etc.I don't expect to immediately break C++20 builds, but I want to be able to come version 3.0