Simple number literal parsing#77
Merged
kylef merged 1 commit intostencilproject:masterfrom Dec 7, 2016
Merged
Conversation
Collaborator
|
Great! I'm 👍 on the change, I just want to get to the bottom of #76 because this adds another use of Float80. |
kylef
approved these changes
Dec 7, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this when trying to do the following:
Which doesn't work, because the rhs Variable evaluates to
nil. This simply adds a number literal parser to allow this expression to work.Small note: I'm purposefully not using a
NumberFormatterto parse the number, because I want to ignore the user's locale for things like the decimal separator. Luckily enough, this simple way of parsing a number evaluates stuff like2twoandthree3to nil, so it really only parses actual numbers.