Skip to content

Updates for https://github.com/stenciljs/core/pull/6292#1532

Merged
christian-bromann merged 18 commits intomainfrom
johnjenkins-patch-1
Jun 13, 2025
Merged

Updates for https://github.com/stenciljs/core/pull/6292#1532
christian-bromann merged 18 commits intomainfrom
johnjenkins-patch-1

Conversation

@johnjenkins
Copy link
Copy Markdown
Contributor

@johnjenkins johnjenkins commented Jun 12, 2025

No description provided.

@vercel
Copy link
Copy Markdown

vercel bot commented Jun 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2025 10:13pm

@johnjenkins johnjenkins changed the title Update extras.md Updates for https://github.com/stenciljs/core/pull/6292 Jun 12, 2025
@johnjenkins johnjenkins mentioned this pull request Jun 12, 2025
Merged
2 tasks
christian-bromann
christian-bromann reviewed Jun 12, 2025
View reviewed changes
christian-bromann
christian-bromann reviewed Jun 12, 2025
View reviewed changes
christian-bromann
christian-bromann reviewed Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the broken link in styling.md? Also can we apply the changes in https://github.com/stenciljs/site/tree/main/docs otherwise they will be gone with the next version release.

@johnjenkins
Copy link
Copy Markdown
Contributor Author

johnjenkins commented Jun 12, 2025

🤤 soz for being stoopid!
Should be ok now

@christian-bromann
Copy link
Copy Markdown
Member

christian-bromann commented Jun 12, 2025

🤤 soz for being stoopid!
Should be ok now

I did some changes to try fix it myself without success. I never fully understood how to resolve links in Docusaurus. Anyway it is still failing due to:

[ERROR] Error: Unable to build website for locale en.
    at tryToBuildLocale (/vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:54:19)
    at async /vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:65:9
    at async mapAsyncSequential (/vercel/path0/node_modules/@docusaurus/utils/lib/jsUtils.js:21:24)
    at async Command.build (/vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:63:5) {
  [cause]: Error: Docusaurus found broken anchors!
  
  Please check the pages of your site in the list below, and make sure you don't reference any anchor that does not exist.
  Note: it's possible to ignore broken anchors with the 'onBrokenAnchors' Docusaurus configuration, and let the build pass.
  
  Exhaustive list of all broken anchors found:
  - Broken anchor on source page path = /docs/next/styling:
     -> linking to /docs/next/config-extras#addGlobalStyleToComponents
  
      at throwError (/vercel/path0/node_modules/@docusaurus/logger/lib/index.js:79:11)
      at reportBrokenLinks (/vercel/path0/node_modules/@docusaurus/core/lib/server/brokenLinks.js:254:49)
      at handleBrokenLinks (/vercel/path0/node_modules/@docusaurus/core/lib/server/brokenLinks.js:282:5)
      at executeBrokenLinksCheck (/vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:199:47)
      at /vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:145:66
      at Object.async (/vercel/path0/node_modules/@docusaurus/core/lib/utils.js:36:47)
      at buildLocale (/vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:145:30)
      at async tryToBuildLocale (/vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:47:13)
      at async /vercel/path0/node_modules/@docusaurus/core/lib/commands/build.js:65:9
      at async mapAsyncSequential (/vercel/path0/node_modules/@docusaurus/utils/lib/jsUtils.js:21:24)
}

@johnjenkins
Copy link
Copy Markdown
Contributor Author

johnjenkins commented Jun 12, 2025

I'm guessing it's the camelCase anchor? :/

@christian-bromann christian-bromann merged commit 8dfc777 into main Jun 13, 2025
5 checks passed
@christian-bromann christian-bromann deleted the johnjenkins-patch-1 branch June 13, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnjenkins @christian-bromann