docs(config): add experimentalScopedSlotChanges extras flag#1307
Merged
tanner-reits merged 5 commits intomainfrom Jan 15, 2024
Merged
docs(config): add experimentalScopedSlotChanges extras flag#1307tanner-reits merged 5 commits intomainfrom
experimentalScopedSlotChanges extras flag#1307tanner-reits merged 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
tanner-reits
commented
Jan 3, 2024
docs/config/extras.md
Outdated
| ### scopedSlotTextContentFix | ||
|
|
||
| An experimental flag that when set to `true`, aligns the behavior of invoking the `textContent` getter/setter on a scoped component to act more like a component that uses the shadow DOM. Specifically, invoking `textContent` on a component will adhere to the return values described in [MDN's article on textContent](https://developer.mozilla.org/en-US/docs/Web/API/Node/textContent#description). Defaults to `false`. | ||
| <!-- TODO(NOW): confirm fix versions --> |
Contributor
Author
There was a problem hiding this comment.
I'll make sure these versions are accurate before this merges, just depends how this lines up with upcoming releases
rwaskiewicz
reviewed
Jan 8, 2024
Member
rwaskiewicz
left a comment
There was a problem hiding this comment.
Overall LGTM - I'll give it another pass once I get to/through the impl PRs
rwaskiewicz
approved these changes
Jan 11, 2024
Member
rwaskiewicz
left a comment
There was a problem hiding this comment.
I approved the impl PR, I'm good with approving now and just landing it after you've bumped the version in the docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
experimentalScopedSlotChangesextras config option to toggle the new behavior forscopedcomponents.Related code changes: stenciljs/core#5220
Note: The first commit only alphabetizes the options, but results in what looks like many more changes