Skip to content

fix: change @import to a @use with wildcard#605

Merged
christian-bromann merged 1 commit intostenciljs:mainfrom
xofromthemoon:chore/change-import-to-use-with-wildcard
Apr 2, 2025
Merged

fix: change @import to a @use with wildcard#605
christian-bromann merged 1 commit intostenciljs:mainfrom
xofromthemoon:chore/change-import-to-use-with-wildcard

Conversation

@xofromthemoon
Copy link
Copy Markdown
Contributor

@xofromthemoon xofromthemoon commented Apr 1, 2025

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: 70

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

I changed the line in @stencil/sass from @import to @use with a wildcard in my stencil project and it builds with no errors.

Other information

@xofromthemoon xofromthemoon requested a review from a team as a code owner April 1, 2025 15:50
Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit b885f42 into stenciljs:main Apr 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants