Handle imports that don’t begin with a “~” correctly#596
Merged
christian-bromann merged 1 commit intostenciljs:mainfrom Mar 7, 2025
alexandertrefz:fix/custom-importer
Merged
Handle imports that don’t begin with a “~” correctly#596christian-bromann merged 1 commit intostenciljs:mainfrom alexandertrefz:fix/custom-importer
christian-bromann merged 1 commit intostenciljs:mainfrom
alexandertrefz:fix/custom-importer
Conversation
Member
|
I think it would make sense to get some tests in place here but happy to have this as a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
@forwardor@use-ing 2 files from the same file creates a Type Error.What is the new behavior?
The file compiles correctly.
Does this introduce a breaking change?