chore(ci): add automated dev releases#467
Merged
rwaskiewicz merged 5 commits intomainfrom Jan 30, 2024
Merged
Conversation
christian-bromann
approved these changes
Jan 26, 2024
Member
christian-bromann
left a comment
There was a problem hiding this comment.
A lot of pipeline code seems very similar to the @stencil/store project. I think there is a way to define these actions in a separate repository and commonly use them across multiple projects. I guess another Jedi day project 😉
LGTM 👍
tanner-reits
approved these changes
Jan 30, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
Yep, the same as our other workflows (for the most part). Time for a monorepo! 😂
this commit implements an initial workflow for dev releases for stencil sass. it is capable of: - generating a build based using the same logic as other ci workflows - generating a dev build version - invoking a publish action with the dev version & 'dev' tag a new publish action is added that is capable of incrementing the version of the package and publishing changes to npm has been added. the intent is to reuse this in some capacity for production releases. this commit also includes additional actions for building the project & downloading/uploading archives. to date, ci has been rather simplistic in this repo. however, it's planned to integrate these actions into existing workflows once this has been added to `main`.
9fc7b02 to
8694f2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Dev releases don't exactly exist for this project. Prereleases are cut and published to the npm registry.
GitHub Issue Number: N/A
What is the new behavior?
this commit implements an initial workflow for dev releases for stencil
sass. it is capable of:
a new publish action is added that is capable of incrementing the
version of the package and publishing changes to npm has been added. the
intent is to reuse this in some capacity for production releases.
this commit also includes additional actions for building the project &
downloading/uploading archives. to date, ci has been rather simplistic
in this repo. however, it's planned to integrate these actions into
existing workflows once this has been added to
main.Does this introduce a breaking change?
Testing
In a73de0c, I had a push event trigger enabled such that when I pushed this branch to GitHub, a dev build would get triggered. I considered this to be safe because:
I also ran the Framework CI workflow using a dev build of stencil sass, which passed https://github.com/ionic-team/ionic-framework/actions/runs/7669946636
Other information