#648 fixed standalone property for angular 19 and above#653
Merged
christian-bromann merged 8 commits intostenciljs:mainfrom Jun 17, 2025
Merged
#648 fixed standalone property for angular 19 and above#653christian-bromann merged 8 commits intostenciljs:mainfrom
christian-bromann merged 8 commits intostenciljs:mainfrom
Conversation
added 7 commits
June 16, 2025 10:24
…or (`||`), as it is a safer operator.
…nents and scams for angular versions 19 and up
Member
|
Thanks @gratzl-dev for the contribution, mind resolving the pnpm-lock issue? |
Contributor
Author
|
Oh, I must've missed that. |
25 tasks
christian-bromann
approved these changes
Jun 17, 2025
Member
christian-bromann
left a comment
There was a problem hiding this comment.
LGTM 👍
I will fix the prettier issue in main.
Thanks a lot! I will release this as v1.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally for affected output targetsnpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Generated Angular Output is not compatible with Angular 19's Standalone property.
Angular 19 introduced standalone as the default, breaking non-standalone stencil components
https://angular.dev/guide/components#using-components
Issue URL: #648
What is the new behavior?
Does this introduce a breaking change?
Stencil Libraries using an Angular Version under 19 will need to use an old Version of @stencil/output-target-angular.
I added a compatibility table in the Readme.