Skip to content

#648 fixed standalone property for angular 19 and above#653

Merged
christian-bromann merged 8 commits intostenciljs:mainfrom
gratzl-dev:bugfix/648_standalone
Jun 17, 2025
Merged

#648 fixed standalone property for angular 19 and above#653
christian-bromann merged 8 commits intostenciljs:mainfrom
gratzl-dev:bugfix/648_standalone

Conversation

@gratzl-dev
Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Generated Angular Output is not compatible with Angular 19's Standalone property.
Angular 19 introduced standalone as the default, breaking non-standalone stencil components

image

https://angular.dev/guide/components#using-components

Issue URL: #648

What is the new behavior?

  • changed standalone components to be the default output type
  • only set standalone property when OutputType is NOT 'standalone'
  • fixed standalone property being in the same line as the input list

Does this introduce a breaking change?

  • Yes
  • No

Stencil Libraries using an Angular Version under 19 will need to use an old Version of @stencil/output-target-angular.
I added a compatibility table in the Readme.

@gratzl-dev gratzl-dev requested a review from a team as a code owner June 16, 2025 08:59
@christian-bromann
Copy link
Copy Markdown
Member

Thanks @gratzl-dev for the contribution, mind resolving the pnpm-lock issue?

@gratzl-dev
Copy link
Copy Markdown
Contributor Author

Oh, I must've missed that.
I'll take a look!

Copy link
Copy Markdown
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I will fix the prettier issue in main.

Thanks a lot! I will release this as v1.0.0

@christian-bromann christian-bromann merged commit 58901dc into stenciljs:main Jun 17, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants