fix(react): Ignore undefined property values#138
Closed
andys8 wants to merge 1 commit intostenciljs:mainfrom
Closed
fix(react): Ignore undefined property values#138andys8 wants to merge 1 commit intostenciljs:mainfrom
andys8 wants to merge 1 commit intostenciljs:mainfrom
Conversation
If a property is set to undefined, instead of missing, this can lead to strange behavior in stencil components. For example default values will be overwritten with undefined. This change will filter 'undefined' values from the properties.
Author
|
@adamdbradley Merging this, would be awesome :) |
This was referenced Apr 23, 2024
Member
|
This is not relevant anymore as we use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
If a property is set to undefined, instead of missing, this can lead to strange behavior in stencil components. For example default values will be overwritten with undefined. This change will filter 'undefined' values from the properties.
Feedback
Are you open to merging this change?