Skip to content

react-component-lib depends on @stencil/core #88

@sentience

Description

@sentience

Having just upgraded to 0.0.7 of the React output target, I got this error in my consuming React project:

/path/to/react-app/src/react-component-lib/createComponent.tsx
TypeScript error in /path/to/react-app/src/react-component-lib/createComponent.tsx(10,36):
Cannot find module '@stencil/core/internal/stencil-public-runtime' or its corresponding type declarations. TS2307

It looks like a runtime dependency on @stencil/core has been introduced into the build output of react-output-target. That would mean that every React app that consumes React proxies would need to add Stencil to its package.json, which I do not believe is how react-output-target is intended to work (and wasn't the case for 0.0.6).

The dependency was introduced by 1b0a49c#diff-0c5775a0b0c1a17c5b8e386f105c1683R10.

Metadata

Metadata

Assignees

Labels

package: react@stencil/react-output-target packagetype: bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions