Added fixes to append public or private keywords#23
Merged
raphaelpor merged 4 commits intostenciljs:mainfrom Nov 25, 2023
Merged
Added fixes to append public or private keywords#23raphaelpor merged 4 commits intostenciljs:mainfrom
raphaelpor merged 4 commits intostenciljs:mainfrom
Conversation
Contributor
limxingzhi
commented
Mar 5, 2021
- appended private keyword to fix own props
- appended private keyword to fix own methods
- appended public keyword to fix decorated props
rwaskiewicz
requested changes
Oct 29, 2021
Member
rwaskiewicz
left a comment
There was a problem hiding this comment.
Thanks! The fixers for own-methods-must-be-private and own-methods-must-be-private work great! I'm a little hesitant to add a fixer to props-must-be-public, would you mind removing that one?
Contributor
|
Also is adding |
- appended private keyword to fix own props - appended private keyword to fix own methods
Collaborator
|
Hey @rwaskiewicz, |
Member
|
@raphaelpor Yes, I think this still looks good. Comparing the current changes to what I have on @limxingzhi's branch from when I initially reviewed, it looks like all the feedback has been addressed. I haven't done any testing, but it looks good to me from the standpoint of my initial review 👍 |
Collaborator
|
@rwaskiewicz Great! I will take a look and merge it for the next release. Thanks! ✌️ |
raphaelpor
approved these changes
Nov 22, 2023
Collaborator
|
@limxingzhi Hello and thanks for your contribution. Sorry for taking so long to review your code. But looks like the tests are failing, now. |
Contributor
Author
|
It has been over a year since I worked on this tech stack, I would be more than happy if someone took over |
jcfranco
referenced
this pull request
in Esri/calcite-design-system
Apr 3, 2024
….7.2 (#9036) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@stencil-community/eslint-plugin](https://togithub.com/stencil-community/stencil-eslint) | [`0.7.1` -> `0.7.2`](https://renovatebot.com/diffs/npm/@stencil-community%2feslint-plugin/0.7.1/0.7.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>stencil-community/stencil-eslint (@​stencil-community/eslint-plugin)</summary> ### [`v0.7.2`](https://togithub.com/stencil-community/stencil-eslint/releases/tag/v0.7.2) [Compare Source](https://togithub.com/stencil-community/stencil-eslint/compare/v0.7.1...v0.7.2) #### What's Changed - Added fixes to append public or private keywords by [@​limxingzhi](https://togithub.com/limxingzhi) in [https://github.com/stencil-community/stencil-eslint/pull/23](https://togithub.com/stencil-community/stencil-eslint/pull/23) - fix(reserved-member-names): improve reserved member check by using `HTMLElement` by [@​jcfranco](https://togithub.com/jcfranco) in [https://github.com/stencil-community/stencil-eslint/pull/101](https://togithub.com/stencil-community/stencil-eslint/pull/101) #### New Contributors - [@​limxingzhi](https://togithub.com/limxingzhi) made their first contribution in [https://github.com/stencil-community/stencil-eslint/pull/23](https://togithub.com/stencil-community/stencil-eslint/pull/23) - [@​jcfranco](https://togithub.com/jcfranco) made their first contribution in [https://github.com/stencil-community/stencil-eslint/pull/101](https://togithub.com/stencil-community/stencil-eslint/pull/101) **Full Changelog**: stenciljs/eslint-plugin@v0.7.1...v0.7.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Esri/calcite-design-system). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.