chore(npm): Attempt to fix issue with Trusted Publishers when using reusable workflows#187
Merged
chore(npm): Attempt to fix issue with Trusted Publishers when using reusable workflows#187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
.github/workflows/in your repository.stenciljs/.github/actions/publish-npm@mainGitHub Issue Number: N/A
What is the new behavior?
publish-npm.yml,release-dev.yml,release-production.yml, andrelease-orchestrator.yml, so releases no longer reusestenciljs/.github/actions/publish-npm@mainrelease-orchestrator.yml (contents: read, id-token: write)
├─→ release-dev.yml (contents: read, id-token: write)
│ └─→ publish-npm.yml (contents: read, id-token: write) ✅
└─→ release-production.yml (contents: read, id-token: write)
└─→ publish-npm.yml (contents: read, id-token: write) ✅
Documentation
N/A
Does this introduce a breaking change?
Testing
Other information
release-orchestrator.ymlneeds to be the one set up in the npm package settings for the Trusted Publishers