chore(npm): Update release npm action to stop using tokens#180
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies, reorganizes test files from .spec.ts to .test.ts naming convention, adjusts Vitest configuration, and modernizes GitHub Actions workflows. The changes include major version bumps for testing libraries (vitest 3→4, jsdom 26→27), TypeScript tooling updates, and expanded test coverage for several ESLint rules.
- Major dependency updates including vitest, jsdom, TypeScript, and @typescript-eslint packages
- Test file reorganization with
.spec.ts→.test.tsrenaming and additional test cases - Vitest configuration adjustments (timeout increase and coverage threshold reduction)
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Increased test timeout and lowered branch coverage threshold |
| tests/rules/strict-mutable/*.test.ts | Renamed from .spec.ts and added new test fixtures |
| tests/rules/strict-boolean-conditions/*.test.ts | New comprehensive test suite with multiple fixtures |
| tests/rules/dependency-suggestions/*.test.ts | New test suite for dependency suggestions rule |
| tests/rules/ban-side-effects/*.test.ts | New test suite for ban-side-effects rule |
| tests/configs/configs.test.ts | New test suite for configuration exports |
| package.json | Updated dependency versions across the board |
| package-lock.json | Lockfile updates for all dependency changes |
| .github/workflows/*.yml | Updated Node.js setup action and added emojis to job names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ban-side-effects,dependency-suggestions,strict-mutable, andstrict-boolean-conditions, leaving major rule branches untested..spec.tsfilenames that Vitest didn’t pick up, fixtures were inline, and several edge cases weren’t exercised.GH_ADMIN_PAT, triggering a context warning when using trusted publishing.GitHub Issue Number: N/A
What is the new behavior?
-Updated test tooling:
-
jsdomto^27.0.1-
@types/jsdomto^27.0.0-
@types/nodeto^24.9.2-
@typescript-eslint/eslint-pluginto^8.46.2-
@typescript-eslint/parserto^8.46.2-
@vitest/coverage-v8to^4.0.5-
eslintto^9.38.0-
rolldown-plugin-dtsto^0.17.3-
typescriptto^5.9.3-
vitestto^4.0.5release.ymlso the job depends solely on OIDC.id-token: write, satisfying npm’s trusted publisher guidance.tests/**/*.test.ts) with dedicated fixtures that cover the previously untested configs and rules..spec.tsfiles to.test.tsand expanded fixtures to cover unions, option toggles, skip logic, and mutable prop handling.Does this introduce a breaking change?
Testing
npm run buildnpm run testConsider triggering dev/stable release jobs to verify OIDC publishing end-to-end.
Other information