Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: N/A
I noticed
minimatch(a build-time dep used for bundling), was in my runtime output adding around 9kb (gzipped) to a minimum project's core runtime!For the last 3 years Stencil has had no visibility of the file size of it's core runtime. The test for it was removed and a 'to-do' was put in place.
What is the new behavior?
The
minimatchspecific issue was due to runtime modules importing from barrel files (obvs). I have made sure all runtime modules now import the specific modules they require.The core runtime module is now ~4kb down from ~13kb (gzipped)
Additionally, I have added a new core module size test which will fail when core is over 8kb (un-gzipped)
Documentation
Does this introduce a breaking change?
Testing
Other information