Merged
Conversation
Uses document tree verification instead of snapshot tests to confirm rendering works for two failing tests. Tests were failing due to some limitations with the testing framework. Specifically that numerous snapshots of the same segment of HTML were not allowed in certain use cases
I've run the formatter and linter. Fixed a linting error in package.json where Windows machines will not run eslint if the targets are wrapped in single quotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses document tree verification instead of snapshot tests to confirm rendering works for two failing tests. Tests were failing due to some limitations with the testing framework. Specifically that numerous snapshots of the same segment of HTML were not allowed in certain use cases
What is the current behavior?
Two WDIO tests were failing due to framework limitations on
toMatchInlineSnapshotGitHub Issue Number: N/A
What is the new behavior?
The tests now verify attribute on the DOM tree for correctness.
Documentation
Does this introduce a breaking change?
Testing
Other information