Add JSON parsing support for custom prop types (Unknown/Any) to provide consistent behavior between SSR and non-SSR environments.#6352
Merged
johnjenkins merged 2 commits intostenciljs:mainfrom Jul 24, 2025
Conversation
- String props: Always remain strings, even if they look like JSON - Number props: Always get parsed as numbers - Boolean props: Always get parsed as Booleans - Custom interface props: Get JSON parsing attempted - Any props: Get JSON parsing attempted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Action) get classified asMEMBER_FLAGS.Unknownand receive no JSON parsingundefinedwhen accessed as an object<my-cmp data='{"param":"value"}'></my-cmp>with@Prop() data: Actionresults inthis.databeingundefinedWhat is the new behavior?
MEMBER_FLAGS.Unknown) andanyprops (MEMBER_FLAGS.Any) now attempt JSON parsing when the string value looks like JSON (starts with{/[and ends with}/])<my-cmp data='{"param":"value"}'></my-cmp>with@Prop() data: Actionnow results inthis.databeing{ param: "value" }Does this introduce a breaking change?
Testing
Added