Revert "fix(ssr): fixes for scoped: true components during SSR (#6311)"#6336
Revert "fix(ssr): fixes for scoped: true components during SSR (#6311)"#6336christian-bromann wants to merge 2 commits intomainfrom
scoped: true components during SSR (#6311)"#6336Conversation
…)" This reverts commit b07dda6.
|
@christian-bromann i’m pretty sure the PR you’re looking for is this one #6298 |
johnjenkins
left a comment
There was a problem hiding this comment.
this is the wrong PR for the flagged errors :)
|
I have pushed a dev build The last Nightly build failing: https://github.com/ionic-team/ionic-framework/actions/runs/16187432460 |
|
I created a reproduction case for you using the testbed from Ionic: https://drive.google.com/file/d/1wR9YqsPo93-iy8v67DFeTyykwcStJW53/view?usp=drive_link .. you can just download it and run it. Confusingly, if I run Please let me know your thoughts and how we want to proceed here? |
|
@christian-bromann this is what I get locally - |
|
|
|
Hold on, still working on a reproduction case |
|
Unfortunately I couldn't zip the reproduction case so here is the manual way: Update Stencil to latest: - "@stencil/core": "4.33.1",
+ "@stencil/core": "4.35.3",in Now running the tests you will see that the tests using lazy components are failing:
Let's validate with the dev build: This should now pass:
|
|
Closing in favor of #6343 |


What is the current behavior?
We are having issues updating Ionic framework due to a change introduced in #6311. The issue we see is in the Angular e2e test where the application just doesn't load:
ionic-team/ionic-framework#30524
cc @johnjenkins
What is the new behavior?
I am reverting the change and make a new release.
Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a