refactor(runtime): don't recreate adoptedStyleSheets#6321
Merged
christian-bromann merged 1 commit intostenciljs:mainfrom Jun 27, 2025
Merged
refactor(runtime): don't recreate adoptedStyleSheets#6321christian-bromann merged 1 commit intostenciljs:mainfrom
christian-bromann merged 1 commit intostenciljs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: N/A
When investigating #6320 I saw that there were places that the adoptedStyleSheets array was being recreated instead of mutated. MDN docs say you should only mutate this array: https://developer.mozilla.org/en-US/docs/Web/API/Document/adoptedStyleSheets
What is the new behavior?
The array is mutated instead of recreated
Documentation
Does this introduce a breaking change?
I don't think this is a breaking change, since we already mutate adoptedStyleSheets here (as an example). However, I believe this was originally done because adoptedStyleSheets used to be frozen: GoogleChrome/web.dev#10294
Because there's other places in the codebase that treat adoptedStyleSheets as mutable I don't think this is breaking but I do want to highlight that.
Testing
Other information