Skip to content

feat(compiler): support maxParallelFileOps in RollupInputOptions#6255

Merged
christian-bromann merged 3 commits intostenciljs:mainfrom
talaat197:feat/compiler-max-parallel-file-ops
May 28, 2025
Merged

feat(compiler): support maxParallelFileOps in RollupInputOptions#6255
christian-bromann merged 3 commits intostenciljs:mainfrom
talaat197:feat/compiler-max-parallel-file-ops

Conversation

@talaat197
Copy link
Contributor

@talaat197 talaat197 commented May 9, 2025

What is the current behavior?

The current implementation does not expose maxParallelFileOps in the Rollup configuration used by the Stencil compiler. This limits the ability to control parallel file operations during the build process as it has a default 20, which can be important for tuning performance on large projects or slower environments.

Closes: 6253

What is the new behavior?

This PR adds support for the maxParallelFileOps option to the Rollup input configuration (RollupInputOptions) used internally by Stencil. This enables developers to configure the maximum number of parallel file operations Rollup can perform, improving control over build performance.

Documentation

Rollup maxparallelfileops

Does this introduce a breaking change?

  • Yes
  • No

Testing

  • Manually tested by building a project with maxParallelFileOps set and verified that Rollup respects the configuration.
  • Existing tests continue to pass.

Other information

@talaat197 talaat197 requested a review from a team as a code owner May 9, 2025 13:47
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

@talaat197 it seems that there is still a linter issue, mind running npm run prettier to resolve it?

@talaat197
Copy link
Contributor Author

@christian-bromann Done

@talaat197 talaat197 force-pushed the feat/compiler-max-parallel-file-ops branch from c96a278 to 719cdd5 Compare May 27, 2025 19:52
@talaat197
Copy link
Contributor Author

@christian-bromann I am not sure why the tests fails with 30000ms timeout, I run before pushing npm run test -- --no-build and it passes 🤔

@christian-bromann christian-bromann merged commit 71cf735 into stenciljs:main May 28, 2025
143 of 144 checks passed
@christian-bromann
Copy link
Member

@talaat197 no worries, we are currently having some issues with those tests. I went ahead and merge the PR. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: stencil build --watch hangs on “generate lazy” when importing large files after Rollup 4 upgrade

2 participants