You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using renderToString with serializeShadowRoot: 'scoped', the children of the host element should properly have the sc-web-component-name class applied and all the defined styles that come with it.
Documentation
Does this introduce a breaking change?
Yes
No
Testing
A new wdio test not checks for scoped classes from renderToString content
to remove the hydrateServerSide, or invert, the check in initializeComponent.ts also seemed to resolve the issue. Not too sure where the correct place to change things here would be here since it seems it can be done in several ways.
I did some playing around trying to get to work on my end and noticed that modifying ...
to remove the hydrateServerSide, or invert, the check in initializeComponent.ts also seemed to resolve the issue. Not too sure where the correct place to change things here would be here since it seems it can be done in several ways.
hey @Armand-Lluka - thanks for your investigation(!) but I don't think we would want to bring the scopeCss methods into the client-side build because it would add quite a number of bytes to the users not using SSR at all :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
When using
renderToStringto hydratescopedweb components, the "scoped" classes are not being applied correctly to the children of the host element.GitHub Issue Number: #6219
What is the new behavior?
When using renderToString with serializeShadowRoot: 'scoped', the children of the host element should properly have the sc-web-component-name class applied and all the defined styles that come with it.
Documentation
Does this introduce a breaking change?
Testing
A new wdio test not checks for scoped classes from renderToString content
Other information
n/a