fix(testing): update puppeteer, default to 'new' headless#6098
Merged
christian-bromann merged 12 commits intomainfrom Jan 16, 2025
Merged
fix(testing): update puppeteer, default to 'new' headless#6098christian-bromann merged 12 commits intomainfrom
christian-bromann merged 12 commits intomainfrom
Conversation
3 tasks
|
Are you now official supporting puppeteer 24? If so, you should pls update the docu (https://stenciljs.com/docs/support-policy) ? |
Member
Author
|
Thanks for reminding! I pushed an update. For v4 the policy has changed from Puppeteer v22 - v24. I doubt that previous promises that we would support Puppeteer v11 were actually accurate. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
We are currently seeing issues in CI pipelines when running Stencils test command. This is related to Puppeteer (v20) trying to start an old version of Chrome (v120) with new headless mode which appears to fail.
NOTE:
This PR removes our Node.js v16 pipelines as we can't support them anymore. If you still use Node.js v16 please update!
What is the new behavior?
This patch allows to set a
browserChanneltesting property to setchanneloption to Chrome stable to ensure we use latest Chrome. As we can't yet update Puppeteer (as we are required to continue support for Node.js v16) this is the only workaround to ensure tests are passing again.Documentation
n/a
Does this introduce a breaking change?
Setting the default value for
browserHeadlessto"new"is technically a breaking change but since the other behavior started to break anyway, this can be considered a bug fix.Testing
n/a
Other information
n/a