fix(declarations): add missing event handler types#5964
Merged
christian-bromann merged 1 commit intomainfrom Aug 30, 2024
Merged
fix(declarations): add missing event handler types#5964christian-bromann merged 1 commit intomainfrom
christian-bromann merged 1 commit intomainfrom
Conversation
tanner-reits
approved these changes
Aug 30, 2024
Member
Author
|
Released in Stencil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: fixes #5963
What is the new behavior?
Added missing event handlers to the public runtime. I am not sure if
onBeforeToggleCaptureoronToggleCaptureare a thing but it seems it makes sense to follow the existing pattern. Happy to remove these.Documentation
Does this introduce a breaking change?
Testing
n/a
Other information
n/a