fix(compiler): prefer localName over originalName by running an empty check on originalName#5943
Merged
christian-bromann merged 2 commits intomainfrom Aug 16, 2024
Merged
Conversation
tanner-reits
requested changes
Aug 16, 2024
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
Double-checked a couple cases around import aliasing (last change that touched this code) and all looks good there. Only ask is to update the PR title since this was the same title as a previous PR and doesn't reflect the actual change
localName over originalName by running an empty check on originalName
localName over originalName by running an empty check on originalNamelocalName over originalName by running an empty check on originalName
Member
Author
|
@tanner-reits dang .. updated title. |
tanner-reits
approved these changes
Aug 16, 2024
Member
Author
|
This patch was published in Stencil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: fixes #5882
What is the new behavior?
We have missed a case where an import type can come with an empty id.
Documentation
Does this introduce a breaking change?
Testing
Enhanced existing unit test.
Other information
n/a