Merged
Conversation
Contributor
|
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/mock-doc/serialize-node.ts | 36 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/build/build-stats.ts | 27 |
| src/compiler/output-targets/dist-lazy/generate-lazy-module.ts | 25 |
| src/compiler/style/test/optimize-css.spec.ts | 23 |
| src/testing/puppeteer/puppeteer-element.ts | 23 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/runtime/vdom/vdom-render.ts | 20 |
| src/runtime/client-hydrate.ts | 19 |
| src/screenshot/connector-base.ts | 19 |
| src/compiler/config/test/validate-paths.spec.ts | 16 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/compiler/transpile/transpile-module.ts | 14 |
| src/runtime/vdom/vdom-annotations.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/build/build-finish.ts | 13 |
| src/compiler/prerender/prerender-queue.ts | 13 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2345 | 418 |
| TS2322 | 398 |
| TS18048 | 310 |
| TS18047 | 100 |
| TS2722 | 38 |
| TS2532 | 34 |
| TS2531 | 23 |
| TS2454 | 14 |
| TS2352 | 13 |
| TS2769 | 10 |
| TS2790 | 10 |
| TS2538 | 8 |
| TS2344 | 5 |
| TS2416 | 4 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2488 | 1 |
| TS2430 | 1 |
Unused exports report
There are 12 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 21 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 145 | CUSTOM |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 115 | Env |
| src/compiler/app-core/app-data.ts | 117 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 123 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 62 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 62 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
45097d3 to
177a189
Compare
Member
Author
|
Note, Steps 3-5 are a little different in the README PR for adding new Jest support after this commit - 09129f4 |
tanner-reits
approved these changes
Oct 26, 2023
Contributor
tanner-reits
left a comment
There was a problem hiding this comment.
Seems like a straightforward port of Jest 28 support ![]()
6243210 to
fbe17dd
Compare
17d1372 to
2c63e3b
Compare
2c63e3b to
0606817
Compare
alicewriteswrongs
approved these changes
Oct 26, 2023
0606817 to
19d85de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Stencil lacks support for Jest 29
GitHub Issue Number: N/A
Note to Reviewers
This PR is meant to follow along with the steps for adding a new version of Jest, currently ready for review (#4952). I suggest reading that in tandem with this PR, each commit in this PR can be directly tied back to a step (there may be >1 commit per step) in that document.
This PR is a child of #4979. I plan on merging that first, then this one. I'll probably wait until both are approved to begin the merging/squashing/rebasing of the two branches
What is the new behavior?
Add support for Jest 29 to Stencil
Does this introduce a breaking change?
Testing
To test, I generated a dev build of the branch -
@stencil/core@4.6.0-dev.1698239124.bd2fbc0Component Starter Testing
I tested this on a Stencil Component Starter (manually).
I started by generating a new project with the dev build:
Then installed each version of jest and tested them:
Ionic Framework
I tested this branch in the Ionic Framework as well.
Note: Node 18 is required to run tests here.
maincd core/ && npm i @stencil/core@4.6.0-dev.1698239124.bd2fbc0npm i jest@29 @types/jest@29 jest-cli@29 @jest/core@29npm run test.spec -- --no-cacheOther information
Docs PR: stenciljs/site#1257
Note to self When it's time to merge, please squash this, add the STENCIL- ticket number and the 'fixes' contents to the squashed commit