chore(karma): remove async and done usage#3262
Merged
rwaskiewicz merged 2 commits intomainfrom Mar 7, 2022
Merged
Conversation
14 tasks
ltm
approved these changes
Mar 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When we upgraded Stencil to internally use Jest 27 (#3171), we began
to see warnings in the console that look something like:
This will be a blocker for an upgrade to Jest 28.
GitHub Issue Number: N/A
What is the new behavior?
I removed either the usage of the
doneparameter orasynckeyword from tests,depending on what was required/based on the structure of the test itself
Does this introduce a breaking change?
Testing
I've run our Karma tests on Browserstack 50 times to try to see if this introduces any additional flakiness to the e2e tests. We saw 13 failures, most of which around disconnects from Browserstack/inability to connect to the browser in the first place. While this number is too high, I don't think it's related to these tests themselves. 😢
Other information