chore(prettier): ignore additional test output directories#3181
Merged
rwaskiewicz merged 2 commits intomainfrom Jan 4, 2022
Merged
chore(prettier): ignore additional test output directories#3181rwaskiewicz merged 2 commits intomainfrom
rwaskiewicz merged 2 commits intomainfrom
Conversation
this commit updates the prettier ignore configuration to use globs for the `dist` and `www` directories under the root `test/` directory. this prevents files in the `test/end-to-end` directory (and others) from being formatted remove `test/browser-compile` to ensure src files are properly formatted. the test output for this directory is covered by the new globs
ltm
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
We run prettier on end to end test output locally 😬 this takes wayyyy longer than it should.
GitHub Issue Number: N/A
What is the new behavior?
this commit updates the prettier ignore configuration to use globs for
the
distandwwwdirectories under the roottest/directory. thisprevents files in the
test/end-to-enddirectory (and others) frombeing formatted
remove
test/browser-compileto ensure src files are properlyformatted. the test output for this directory is covered by the new
globs
Does this introduce a breaking change?
Testing
In the
HEADofmain, run thetest/end-to-endtests locally. Then run prettier (npm run prettierfrom the root of the project). Note all the output files being formatted.Then checkout this branch, and run prettier again. Notice that it doesn't run on the compiled output anymore.
Other information