Skip to content

chore(prettier): ignore additional test output directories#3181

Merged
rwaskiewicz merged 2 commits intomainfrom
exclude-e2e-prettier
Jan 4, 2022
Merged

chore(prettier): ignore additional test output directories#3181
rwaskiewicz merged 2 commits intomainfrom
exclude-e2e-prettier

Conversation

@rwaskiewicz
Copy link
Copy Markdown
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

We run prettier on end to end test output locally 😬 this takes wayyyy longer than it should.

GitHub Issue Number: N/A

What is the new behavior?

this commit updates the prettier ignore configuration to use globs for
the dist and www directories under the root test/ directory. this
prevents files in the test/end-to-end directory (and others) from
being formatted

remove test/browser-compile to ensure src files are properly
formatted. the test output for this directory is covered by the new
globs

Does this introduce a breaking change?

  • Yes
  • No

Testing

In the HEAD of main, run the test/end-to-end tests locally. Then run prettier (npm run prettier from the root of the project). Note all the output files being formatted.

Then checkout this branch, and run prettier again. Notice that it doesn't run on the compiled output anymore.

Other information

this commit updates the prettier ignore configuration to use globs for
the `dist` and `www` directories under the root `test/` directory. this
prevents files in the `test/end-to-end` directory (and others) from
being formatted

remove `test/browser-compile` to ensure src files are properly
formatted. the test output for this directory is covered by the new
globs
@rwaskiewicz rwaskiewicz requested a review from a team December 10, 2021 16:15
@rwaskiewicz rwaskiewicz merged commit 94de9dd into main Jan 4, 2022
@rwaskiewicz rwaskiewicz deleted the exclude-e2e-prettier branch January 4, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants